[webkit-reviews] review granted: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9271] better patch with change log, can still use the old test case

[bugzilla-request-daemon at opendarwin.org]

Geoffrey Garen <ggaren at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is
always "undefined"
http://bugzilla.opendarwin.org/show_bug.cgi?id=9622

Attachment 9271: better patch with change log, can still use the old test case
http://bugzilla.opendarwin.org/attachment.cgi?id=9271&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

I think kjs_window.cpp could use a comment explaining why you need to do this:

+    if (!returnValue)
+	 returnValue = dialogWindow->getDirect("returnValue");

Also, it looks like you changed the indenting in KJSProxy::clear from 4 spaces
to 2.