[webkit-reviews] review denied: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9213] Improved patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs
http://bugzilla.opendarwin.org/show_bug.cgi?id=8251

Attachment 9213: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9213&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Sorry to be difficult, but there is at least one problem here. If the macro is
going to be in Platform.h, then the prefix should not be WEBCORE_ but rather
WTF_. But also, if it's going to be in Platform.h it has to be the whole macro,
not just the PPC part, with the WIN32 bit etc.

I think we should go back to something more like the original patch that's in
kjs_navigator.cpp, but not with something that starts with an underscore. I
think that you should use PLATFORM(PPC) instead of a custom ifdef. And I think
that all the platforms should use the macro instead of having ifdefs in the
Platform case in the casae statement.