[webkit-reviews] review denied: [Bug 9754] S60WebKit should use svn
scripts from WebKit ToT : [Attachment 9233] port of
svn/changelog utilities
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Jul 6 13:00:28 PDT 2006
David Carson <david.carson at nokia.com> has denied David Carson
<david.carson at nokia.com>'s request for review:
Bug 9754: S60WebKit should use svn scripts from WebKit ToT
http://bugzilla.opendarwin.org/show_bug.cgi?id=9754
Attachment 9233: port of svn/changelog utilities
http://bugzilla.opendarwin.org/attachment.cgi?id=9233&action=edit
------- Additional Comments from David Carson <david.carson at nokia.com>
Generated paths in ChangeLog are not consistent, ie:
* S60Tools\prepare-ChangeLog.bat: Added.
* S60Tools\svn-apply.bat: Added.
* S60Tools\svn-create-patch.bat: Added.
* S60Tools\svn-unapply.bat: Added.
* WebKit/BrowserCore/Formcontrols/src/FControlInputSkin.cpp:
(CFormInputSkin::WaitForLastCharCommit):
* WebKit/ResourceLoader/src/HttpPostDataSupplier.cpp:
(THttpPostDataSupplier::GetNextDataPart):
* WebKit\BrowserCore\Formcontrols\src\FControlInputSkin.cpp:
* WebKit\ResourceLoader\src\HttpPostDataSupplier.cpp:
And ChangeLogs should exist in each component, and not just the top level
component.
More information about the webkit-reviews
mailing list