[webkit-reviews] review requested: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9214] Add an m_alignRight flag to InlineTextBox

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Jul 5 13:08:23 PDT 2006


opendarwin.org at mitzpettel.com has asked  for review:
Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right
http://bugzilla.opendarwin.org/show_bug.cgi?id=9670

Attachment 9214: Add an m_alignRight flag to InlineTextBox
http://bugzilla.opendarwin.org/attachment.cgi?id=9214&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
I think this version performs better since it measures the width only if it's
really needed, even for RTL text with the relevant style (whereas the other
approach measures the width of all RTL text with that style).

Can m_toAdd be negative? If it can't, then the sign bit can be reclaimed.



More information about the webkit-reviews mailing list