[webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9198] my alternate version of the fmod patch

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 9678: fmod function of MS CRT returns NaN for x / Inf
http://bugzilla.opendarwin.org/show_bug.cgi?id=9678

Attachment 9198: my alternate version of the fmod patch
http://bugzilla.opendarwin.org/attachment.cgi?id=9198&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This looks ok too, but I kinda like MathExtras.h being transparent and letting
you use the normal function names. Saying wtf_fmod all over (w/ potential to
mistakenly say fmod) seems worse to me than a macro solution. Agreed though
that a macro with parameters would be better.