[webkit-reviews] review denied: [Bug 8251] netscape.product
incorrect in WebKit.app on Intel Macs : [Attachment 9194]
First attempt
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Jul 4 14:41:47 PDT 2006
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs
http://bugzilla.opendarwin.org/show_bug.cgi?id=8251
Attachment 9194: First attempt
http://bugzilla.opendarwin.org/attachment.cgi?id=9194&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Seems fine to do this, but:
1) We should be taking advantage of the <wtf/Platform.h> header instead of
adding still more one-off ifdefs.
2) A name of format _PLATFORM is reserved for the standard C library. Don't
use leading underscores for this sort of thing. How about
WEBCORE_NAVIGATOR_PLATFORM or something like that?
More information about the webkit-reviews
mailing list