[webkit-reviews] review granted: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9191] extended test case to more extensively test error cases and code paths

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jul 4 10:33:00 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9506: Implement HSL, and HSLA colors in WebKit
http://bugzilla.opendarwin.org/show_bug.cgi?id=9506

Attachment 9191: extended test case to more extensively test error cases and
code paths
http://bugzilla.opendarwin.org/attachment.cgi?id=9191&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Based on Maciej's earlier review, I'll say r=me.

You didn't really address all my comments. For example, there's still no URL of
a source for the color algorithm. But lets just get this into the tree as-is.



More information about the webkit-reviews mailing list