[webkit-reviews] review denied: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9119] Align RTL white-space:pre text with the right edge of the text box

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right
http://bugzilla.opendarwin.org/show_bug.cgi?id=9670

Attachment 9119: Align RTL white-space:pre text with the right edge of the text
box
http://bugzilla.opendarwin.org/attachment.cgi?id=9119&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I agree with darin's comment about offsetForAlignRight.

I think if there is extra space around in an existing bitfield, it is ok to use
one of those bits. However, this should be justified with some kind of
measurement of the perf impact. I think since m_reversed is checked first, then
at least the LTR case should be optimized already, but perhaps in many RTL
cases the other calculations can be skipped.

r-  so you can decide what to do here but I think the patch is good to go
either way (assuming I am right that LTR should normally be unaffected).