[webkit-reviews] review requested: [Bug 9678] fmod function of MS
CRT returns NaN for x / Inf : [Attachment 9183] Workaround
for MSVCRTs fmod function
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Jul 3 20:20:50 PDT 2006
Björn Graf (boki) <bjoern.graf at gmail.com> has asked for review:
Bug 9678: fmod function of MS CRT returns NaN for x / Inf
http://bugzilla.opendarwin.org/show_bug.cgi?id=9678
Attachment 9183: Workaround for MSVCRTs fmod function
http://bugzilla.opendarwin.org/attachment.cgi?id=9183&action=edit
------- Additional Comments from Björn Graf (boki) <bjoern.graf at gmail.com>
This patch implements the necessary workaround in wtf/MathExtras.h.
Defining fmod inside the KJS namespace would have worked, if all call sites
where in the namespace explicitly. However, being implicitly declared in the
namespace and defined in it via the using namespace KJS; directive requires the
#define workaround.
Needed to change isinf() because NaN is not finite.
More information about the webkit-reviews
mailing list