[webkit-reviews] review denied: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9171] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 3 17:48:37 PDT 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged
http://bugzilla.opendarwin.org/show_bug.cgi?id=8210

Attachment 9171: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=9171&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think that _web_isConditionalRequest would be more efficient if it called
valueForHTTPHeaderField: instead of keyEnumerator. It's almost going out of its
way to be slow!

Also, why not return BOOL rather than bool since it's a Objective-C method?

Otherwise, looks fine.



More information about the webkit-reviews mailing list