[webkit-reviews] review requested: [Bug 9179] Implement
select.options.add() method : [Attachment 9174] Patch v2
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Jul 3 12:05:55 PDT 2006
David Kilzer (ddkilzer) <ddkilzer at kilzer.net> has asked for review:
Bug 9179: Implement select.options.add() method
http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
Attachment 9174: Patch v2
http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at kilzer.net>
Updates since Patch v1 not covered in Comment #12:
- Implemented IDL function overloading by introducing the "Optional" extended
attribute for parameters. Updated the GenerateImplementation() subroutine in
CodeGeneratorJS.pm to incrementally check the argument list count as it
processes optional parameters to determine when the argument list is complete.
Extracted the GenerateImplementationFunctionCall() subroutine. Note that the
"Optional" attribute only has to be listed on one argument since all others
following it are assumed to be optional as well.
- Added ChangeLog entries.
More information about the webkit-reviews
mailing list