[webkit-reviews] review granted: [Bug 9631] [Drosera] Add "Step
Over" and "Step Out" : [Attachment 9163] Implements step over
and step out
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Jul 3 01:08:46 PDT 2006
Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 9631: [Drosera] Add "Step Over" and "Step Out"
http://bugzilla.opendarwin.org/show_bug.cgi?id=9631
Attachment 9163: Implements step over and step out
http://bugzilla.opendarwin.org/attachment.cgi?id=9163&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I think it would be cleaner to have a line ending array, or regex. Since you
seem to be using the same copy/paste list all over the place. I guess the list
of line endings isn't ever going to change though, so it's not a huge deal.
Looks good. r=me
More information about the webkit-reviews
mailing list