[webkit-reviews] review denied: [Bug 9698] Switch JSC Bindings from
CFDictionary to HashMap : [Attachment 9148] Make NPRuntime
use HashMap
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Jul 2 16:22:01 PDT 2006
Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 9698: Switch JSC Bindings from CFDictionary to HashMap
http://bugzilla.opendarwin.org/show_bug.cgi?id=9698
Attachment 9148: Make NPRuntime use HashMap
http://bugzilla.opendarwin.org/attachment.cgi?id=9148&action=edit
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Our style guidlines also call for splitting lines like this into two:
+ if (!stringIdentifierDictionary) stringIdentifierDictionary = new
HashMap< const char *, PrivateIdentifier *>();
The patch looks correct overall.
More information about the webkit-reviews
mailing list