[webkit-reviews] review granted: [Bug 9674] REGRESSION (r15075): Blank or incomplete pages on digg.com : [Attachment 9121] Save and restore the m_requestingScript flag
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Jul 1 14:38:24 PDT 2006
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com
http://bugzilla.opendarwin.org/show_bug.cgi?id=9674
Attachment 9121: Save and restore the m_requestingScript flag
http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I think of the m_state as a more-or-less arbitrary set of bits, so the argument
about this bit being global state and hence "not part of state" doesn't seem
very compelling to me.
Your argument about a byte on the stack vs. a count in the tokenizer object is
actually a pretty compelling one. It didn't occur to me that the stack cost can
be paid over and over again as you recurse and there is only one tokenizer.
I think that either the original fix or this one is fine. r=me
More information about the webkit-reviews
mailing list