[webkit-reviews] review requested: [Bug 6309] Bookmarking/Back Button Support for AJAX/DHTML Applications in Safari is Impossible : [Attachment 6174] Patch v1 (probably not final fix)

[bugzilla-request-daemon at opendarwin.org]

David D. Kilzer <ddkilzer at kilzer.net> has asked  for review:
Bug 6309: Bookmarking/Back Button Support for AJAX/DHTML Applications in Safari
is Impossible
http://bugzilla.opendarwin.org/show_bug.cgi?id=6309

Attachment 6174: Patch v1 (probably not final fix)
http://bugzilla.opendarwin.org/attachment.cgi?id=6174&action=edit

------- Additional Comments from David D. Kilzer <ddkilzer at kilzer.net>
Poking around kjs_window.cpp, I found that the change in this patch would fix
the attached test case (Attachment 6173).

The change from calling scheduleLocationChange() to changeLocation() causes the
Redirection Timer not to spin endlessly after the test case is done.

The change from "!userGesture" to "false" in the third argument causes the
history to be written for each change to the URL fragment/reference
(#locationX).

I have no idea if this is the correct fix, though, since it takes a while for
the "Back" history button to update after the test case is run, and the test
case seems to reload the entire page every time.  It seems like there is a
missing optimization where loading a URL fragment (#locationX) on the same page
shouldn't force the entire page to be reloaded.