[webkit-reviews] review requested: [Bug 6893] REGRESSION: Major bug with TinyMCE, no value submitted from textarea : [Attachment 6170] patch

[bugzilla-request-daemon at opendarwin.org]

Justin Garcia <justin.garcia at apple.com> has asked  for review:
Bug 6893: REGRESSION: Major bug with TinyMCE, no value submitted from textarea
http://bugzilla.opendarwin.org/show_bug.cgi?id=6893

Attachment 6170: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6170&action=edit

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
Replaces \r\ns and \rs with \n in setValue so that \rs never get into the
renderer.  Removes the code from KWQTextArea for working around \rs.  Only
retrieve text with hard line wraps when appending form data, not when returning
.value, to match the spec and other browsers.

Now that the renderer and the textarea element track the same value (a \rless
string without \ns for hard line wraps), some simplification is possible.  The
HTMLTextAreaElementImpl's value only becomes invalidated on
RenderTextArea::slotTextChanged.  A textareas m_value is only recomputed from
the renderer if 1) the renderer is about to be destroyed or 2) if m_value is
invalid and someone calls .value on a rendered textarea.

Also fixes <rdar://problem/3968059> Textarea with hard-wrap: pre-filled text
doesn't get hard-wrapped