[webkit-reviews] review granted: [Bug 6907] REGRESSION: United.com menus messed up due to document.all/MSIE sniff : [Attachment 6136] fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jan 30 22:32:17 PST 2006


Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 6907: REGRESSION: United.com menus messed up due to document.all/MSIE sniff
http://bugzilla.opendarwin.org/show_bug.cgi?id=6907

Attachment 6136: fix
http://bugzilla.opendarwin.org/attachment.cgi?id=6136&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good, r=me.

Two comments: 1) lets get rid of the exec parameter to isEqualToNull; 2) lets
think about giving that function a better name, since it's not just about being
equal to null any more



More information about the webkit-reviews mailing list