[webkit-reviews] review denied: [Bug 5146] max-height/max-width not resizing images with correct aspect ratio : [Attachment 6081] patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Sam Weinig <sam.weinig at gmail.com>'s
request for review:
Bug 5146: max-height/max-width not resizing images with correct aspect ratio
http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

Attachment 6081: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6081&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks really good. Thanks for doing this!

But we also need a layout test in the patch to land the test. The tests
attached to the bug look pretty good, we just need to turn them into layout
tests and include them along with expected results in the patch.

I also think that these lines:

+    
+    if (width > maxW)
+	 width = maxW;
+    
+    if (width < minW)
+	 width = minW;
+    
+    return width;

would read better if it instead it just said:

    return kMax(minW, kMin(width, maxW));

Setting review- due to the lack of a layout test.