[webkit-reviews] review requested: [Bug 6889] SVG tetris does not work with WebKit+SVG : [Attachment 6048] patch to fix SVG Tetris.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jan 28 06:39:38 PST 2006

Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 6889: SVG tetris does not work with WebKit+SVG

Attachment 6048: patch to fix SVG Tetris.

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Aw hell.  I was close enough, I figured I'd just fix the whole darn SVG.  There
were 3 issues which I fixed here:

1.  I fixed dynamic viewport updates (previously they were ignored).
2.  I fixed absoluteTransform so that invalidation works (mostly... there still
seems to be an issue or two).
3.  I fixed MacFrame.mm to pass keydown correctly to nonhtml documents.

The only part I can see anyone disagreeing with is #3 (perhaps the code should
use documentElement() all the time instead of body()?

There is also one small piece of my bug fix for CDF (from earlier this evening)
shown in this patch.

More information about the webkit-reviews mailing list