[webkit-reviews] review requested: [Bug 5163] RealPlayer.GetTitle() Crashes Safari/Dashboard : [Attachment 6029] proposed fix

[bugzilla-request-daemon at opendarwin.org]

Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 5163: RealPlayer.GetTitle() Crashes Safari/Dashboard
http://bugzilla.opendarwin.org/show_bug.cgi?id=5163

Attachment 6029: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=6029&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
I have thought about a correct encoding to be used as a fallback a lot, but
still have big reservations about it... I chose kCFStringEncodingWindowsLatin1
(AKA windows-1252), because:
1) I'm running a system with primary Russian, and "LATIN SMALL LETTER A WITH
RING ABOVE" was still encoded as 0xE5, and not turned into a question mark or
something. So. RealPlayer either treats its strings as dumb 8-bit buffers, or
applies a Roman-only Mac<->Windows conversion. It's impossible to decide from
this test case, because 0xe5 has the same meaning in both encodings.
2) CFStringGetSystemEncoding() is inappropriate - if we were to depend on the
system primary language, we'd need the closest Windows encoding, not a Mac one.


Firefox simply stops decoding the string when it sees an invalid byte (so, the
name is displayed as "P1 - Fr" in the test case).

Thoughts?