[webkit-reviews] review denied: [Bug 6878] Clean up CachedImage : [Attachment 6026] Cleanup.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jan 27 13:58:17 PST 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 6878: Clean up CachedImage

Attachment 6026: Cleanup.

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Posting a new patch.  I think validRect is a pretty good name after all so
switching back.

I'm also adding an isValid() method to cachedimages to handle the size ==
rect.size() + !errorimage check.

I also noticed a bug in the width and height methods of the image element. 
They use validRect and they should have been using imageSize.

More information about the webkit-reviews mailing list