[webkit-reviews] review denied: [Bug 6838] Incomplete repaint of collapsed table borders : [Attachment 5990] Basis for a possible fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jan 27 08:50:32 PST 2006

Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 6838: Incomplete repaint of collapsed table borders

Attachment 5990: Basis for a possible fix

------- Additional Comments from Darin Adler <darin at apple.com>
I'm disappointed we have to add so much new code, but it looks pretty good to
me. Is there any way to share more of this? Should we invent a structure that
holds the four separate widths so it can be a single function instead of 4?

I believe you forgot to mark the functions virtual.

+    const BorderValue sb = style()->borderRight();

We normally don't mark local variables const.

+    return int(borderWidth / 2.0 + 0.5);

Can be done more efficiently by doing (borderWidth + 1) / 2. This idiom comes
up multiple times.

More information about the webkit-reviews mailing list