[webkit-reviews] review requested: [Bug 5776] REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not calculated right : [Attachment 6023] Proposed patch 2

[bugzilla-request-daemon at opendarwin.org]

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 5776: REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not
calculated right
http://bugzilla.opendarwin.org/show_bug.cgi?id=5776

Attachment 6023: Proposed patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=6023&action=edit

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
Updated patch to address comments from Darin:
- Remove use of isSameNode
- Clean up use of return to be more clear in if statements
- Use of for loops instead of while in appropriate locations
- Move declaration of found local variable in getPrevListNode
- Remove unneeded local variable in attach -- prevListNode() is correct, we
want to know if the new node is the first node in the list here
- Remove extraneous function in render_list.cpp from earlier attempt at patch
without use of DOM tree
- Use static_cast not a C-style case
- Check that DOM node is an HTML LI node in render_list.cpp