[webkit-reviews] review granted: [Bug 5975] WebCore needs to use KDOM-like DOM binding autogeneration : [Attachment 5923] Address comments

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jan 24 13:06:16 PST 2006


Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 5975: WebCore needs to use KDOM-like DOM binding autogeneration
http://bugzilla.opendarwin.org/show_bug.cgi?id=5975

Attachment 5923: Address comments
http://bugzilla.opendarwin.org/attachment.cgi?id=5923&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Don't forget to put copyright and license information in the patch.

I'm not clear on why we need to use /usr/bin/env to invoke perl.

JavaScript has a capital S and that's not right in the Xcode project.

Looks fine, r=me.



More information about the webkit-reviews mailing list