[webkit-reviews] review granted: [Bug 6752] Make pointer hash the default for all pointers (plus other Hash improvements) : [Attachment 5902] cleanup patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 6752: Make pointer hash the default for all pointers (plus other Hash
improvements)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6752

Attachment 5902: cleanup patch
http://bugzilla.opendarwin.org/attachment.cgi?id=5902&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Funny, I have the same patch for htmlfactory.cpp -- I can discard that now.

+    AtomicString n = getAttribute(nameAttr);

Why not make that const AtomicString&? Also, HTMLGenericFormElementImpl::name()
can also return const AtomicString& if we have a way to get a reference to a
global empty atomic string. In general it's great to have functions that return
const AtomicString& when they are attributes to avoid any reference count
churn.

Looks good. I didn't spot any problems.

r=me