[webkit-reviews] review denied: [Bug 6403] Windows patch: KJS_EXPORT for building DLLs : [Attachment 5726] KJS_EXPORT

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jan 22 12:04:05 PST 2006

Darin Adler <darin at apple.com> has denied Justin Haygood <jhaygood at spsu.edu>'s
request for review:
Bug 6403: Windows patch: KJS_EXPORT for building DLLs

Attachment 5726: KJS_EXPORT 

------- Additional Comments from Darin Adler <darin at apple.com>
I don't think we want a FIXME in config.h for the possible future use of
KJS_EXPORT for GCC visibility control; lets remove that for now.

The JSValue stuff should not be in an #if !WIN32 ifdef, because we do want
those undefined copy constructor and assignment operators on Windows. Better
would be to actually define them in value.cpp, but only when we are building a
DLL on Windows. I don't think that WIN32 alone is good enough to indicate
"building a DLL". For example, I know we might want to build a static library
for Windows rather than a DLL, so we don't want ifdefs that assume "WIN32 ==

Setting review- just because of the the value.h thing -- otherwise looks great,
and about ready to land.

More information about the webkit-reviews mailing list