[webkit-reviews] review requested: [Bug 3702] Web page is laid out incorrectly after printing with print-specific style sheet : [Attachment 5844] revised fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jan 22 11:35:20 PST 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 3702: Web page is laid out incorrectly after printing with print-specific
style sheet
http://bugzilla.opendarwin.org/show_bug.cgi?id=3702

Attachment 5844: revised fix
http://bugzilla.opendarwin.org/attachment.cgi?id=5844&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
> Instead, iterate all children (starting with the
> first child, not firstBody), call the loop variable child instead of body,
> handle all table sections, and don't special case the head or the foot.

  /me blushes and hopes he didn't overlook something equally stupid this time
:(

> (Patch has some tab characters in it. Please don't check in with tabs.)

  These files have a lot of tabs, would you like me to replace them all when
committing?



More information about the webkit-reviews mailing list