[webkit-reviews] review requested: [Bug 3527] Allow Safari to open postscript files in browser windows as well : [Attachment 5835] Patch v1 (initial hack)

[bugzilla-request-daemon at opendarwin.org]

David D. Kilzer <ddkilzer at kilzer.net> has asked  for review:
Bug 3527: Allow Safari to open postscript files in browser windows as well
http://bugzilla.opendarwin.org/show_bug.cgi?id=3527

Attachment 5835: Patch v1 (initial hack)
http://bugzilla.opendarwin.org/attachment.cgi?id=5835&action=edit

------- Additional Comments from David D. Kilzer <ddkilzer at kilzer.net>
This patch is basically a first-pass hack at viewing of PostScript files work
in Safari.  Looking for feedback on the following:

- Class design.  I basically copied WebPDFRepresentation.h/m to
WebPostScriptRepresentation.h/m, changed the class names, and added code to the
finishedLoadingWithDataSource() method.  Is there a better way to do this? 
Should I create a base class for them?	Or combine them into a single class and
conditionalize the PS-to-PDF conversion (not very OO-design-worthy, though)?

- Am I doing anything stupid with the Core Graphics APIs or not releasing
references that I should in the PS-to-PDF code?  Specifically, am I using
"toll-free" casts?

- The CGDataConsumerCreateWithCFData() call was added in 10.4.	Is this an
issue (backward compatibility with 10.3)?

- Is there a better way to check the value of 'success'?