[webkit-reviews] review requested: [Bug 5964] Animation (<animateColor>, <animateTransform>, etc) are broken after DOM Merger : [Attachment 5826] Makes animation work again.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jan 21 22:57:35 PST 2006

Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 5964: Animation (<animateColor>, <animateTransform>, etc) are broken after
DOM Merger

Attachment 5826: Makes animation work again.

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This patch makes <animateColor> work again.  It stopped working because the
timers were never started.  During the DOM merger I moved much of the
SVGDocumentImpl logic onto SVGSVGElementImpl in an effort not to modify
DocumentImpl too much.	Now I've created a SVGDocumentExtensions class to hold
all of the SVGDocumentImpl specific goop.  Eventually we'll create an
HTMLDocumentExtensions class and that can hold all the HTML specific goop which
is currently found in DocumentImpl.

More information about the webkit-reviews mailing list