[webkit-reviews] review denied: [Bug 3702] Web page is laid out
incorrectly after printing with print-specific style sheet :
[Attachment 5809] proposed fix
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Jan 21 11:07:32 PST 2006
Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 3702: Web page is laid out incorrectly after printing with print-specific
style sheet
http://bugzilla.opendarwin.org/show_bug.cgi?id=3702
Attachment 5809: proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=5809&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This doesn't look right to me.
This code is iterating all the columns in one of the table sections, but then
it's cutting back the number of columns in the table itself. But there can be
other table sections, and they may have different numbers of columns.
Also, it's not good design to have the table section resizing the table's
column data structures. The table should maintain the size of its own. And a
function named ensureRows should not change the columns data structure around.
Finally, I don't understand how this fixes the bug -- what goes wrong without
this code? How are the column data structures supposed to be set up by
RenderTable? What's going wrong with that in this case?
More information about the webkit-reviews
mailing list