[webkit-reviews] review denied: [Bug 6530] Fixed-pitch font detection doesn't work for many fonts : [Attachment 5664] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jan 21 10:57:07 PST 2006

Darin Adler <darin at apple.com> has denied David D. Kilzer
<ddkilzer at kilzer.net>'s request for review:
Bug 6530: Fixed-pitch font detection doesn't work for many fonts

Attachment 5664: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Adding more special cases for fonts that are incorrectly reported as fixed
pitch is fine. But I do want each of the fonts that behave wrong in this
respect reported to the AppKit team in a bugreport.apple.com bug report (not
necessarily a separate one for each font family). I don't think it's good to
remove the list of bug numbers and fonts that were mentioned in those bugs from
the code. We could convert it to a more-terse format, but I want to keep a
connecton between special case family names and the bug reports mentioning the
need for them.

I'm not sure that the NSFixedPitchFontMask in the traits should be identical to
the results of isFontFixedPitch: -- since the former is used for selecting
fonts, and the latter is used to ensure that glyph widths all match it's not
clear to me that they need to be in sync. But perhaps there's concrete reason
why it's important to have both contain the exception list. Can you explain

More information about the webkit-reviews mailing list