[webkit-reviews] review denied: [Bug 6663] KWQDateTime shouldn't use CoreFoundation : [Attachment 5772] Makes it use standard C time functions

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jan 19 22:11:10 PST 2006

Darin Adler <darin at apple.com> has denied Justin Haygood <jhaygood at spsu.edu>'s
request for review:
Bug 6663: KWQDateTime shouldn't use CoreFoundation

Attachment 5772: Makes it use standard C time functions

------- Additional Comments from Darin Adler <darin at apple.com>
I don't want to take this approach.

If we're going to use standard C functions, then I don't think we should bother
with the QTime and QDateTime classes at all. Instead, the 2-4 places that use
QTime and QDateTime should use the appropriate standard library call. And if we
need some helper functions in the platform directory, that would be OK.

We're talking only a few places in all the code:

    1) htmltokenizer.h/cpp
    2) ContainerNodeImpl.cpp
    3) dom2_eventsimpl.cpp

More information about the webkit-reviews mailing list