[webkit-reviews] review denied: [Bug 6553] KCanvas needs to be
redesigned to fill & stroke at once :
[Attachment 5694] remove kcanvascommonargs (pass around only renderpath)
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Jan 15 06:31:38 PST 2006
Anders Carlsson <andersca at mac.com> has denied Alexander Kellett
<webkit at lypanov.net>'s request for review:
Bug 6553: KCanvas needs to be redesigned to fill & stroke at once
http://bugzilla.opendarwin.org/show_bug.cgi?id=6553
Attachment 5694: remove kcanvascommonargs (pass around only renderpath)
http://bugzilla.opendarwin.org/attachment.cgi?id=5694&action=edit
------- Additional Comments from Anders Carlsson <andersca at mac.com>
Patch looks great, a few minor comments though:
- for pointer types (such as RenderPath), the * should be next to the
identifier, not the type.
- The RenderPath parameter should really be const. This might require having to
modify other function declarations called by the different draw implementations
More information about the webkit-reviews
mailing list