[webkit-reviews] review granted: [Bug 6549] Move shared.h from khtml/misc to platform/Shared.h : [Attachment 5687] Patch that does the move.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jan 15 04:56:18 PST 2006


Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 6549: Move shared.h from khtml/misc to platform/Shared.h
http://bugzilla.opendarwin.org/show_bug.cgi?id=6549

Attachment 5687: Patch that does the move.
http://bugzilla.opendarwin.org/attachment.cgi?id=5687&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
See <http://wiki.opendarwin.org/index.php?title=WebKit:Renaming_Proposals>.

We plan to rename the Shared class to "RefCounted", so I think it's a mistake
to rename and move the file and change the namespace of every use without also
doing the renaming.

The mechanics of what you did here is fine, but please consider renaming to
RefCounted.



More information about the webkit-reviews mailing list