[webkit-reviews] review granted: [Bug 5974] <foreignObject> is unimplemented : [Attachment 5641] Implements foreignObject (and makes a couple other fixes to related code)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jan 13 07:44:23 PST 2006


Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5974: <foreignObject> is unimplemented
http://bugzilla.opendarwin.org/show_bug.cgi?id=5974

Attachment 5641: Implements foreignObject (and makes a couple other fixes to
related code)
http://bugzilla.opendarwin.org/attachment.cgi?id=5641&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Do lines like this one:

+    totalTransform.invert().map((double)_x, (double)_y, &localX, &localY);

really need type casts?

Looks good, r=me.



More information about the webkit-reviews mailing list