[webkit-reviews] review denied: [Bug 5153] deleteRule and
insertRule do not work : [Attachment 5620] Fix
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Jan 12 09:34:25 PST 2006
Darin Adler <darin at apple.com> has denied Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 5153: deleteRule and insertRule do not work
http://bugzilla.opendarwin.org/show_bug.cgi?id=5153
Attachment 5620: Fix
http://bugzilla.opendarwin.org/attachment.cgi?id=5620&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ removeRule DOMCSSStyleSheet::RemoveRule DontDelete|Function 0
Number of parameters here should be 1, not 0.
This patch makes two fixes. One is about updating the disabled flag on style
sheets. That fix has no layout test. I think that fix should be landed
separately, but it might be OK to land them together if there was a test for
it.
Otherwise, looks great.
More information about the webkit-reviews
mailing list