[webkit-reviews] review granted: [Bug 5870] Double-clicking on an SVG dies in HTML editing code : [Attachment 5583] patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 5870: Double-clicking on an SVG dies in HTML editing code
http://bugzilla.opendarwin.org/show_bug.cgi?id=5870

Attachment 5583: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=5583&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This could be improved:

+    // Allows [br, 1] as a position, though that is incorrect
+    if (node->hasTagName(brTag) || (renderer && (renderer->isReplaced() ||
renderer->isWidget())))
+	 return 1;

The isWidget check isn't needed, because all widgets are replaced. Also, the
comment mentions <br>, but the same "wrongness" is true about replaced elements
with offset 1, so the comment should mention both.