[webkit-reviews] review denied: [Bug 6452] KIO::appendEscapingBadChars() doesn't know about %u-escaping. : [Attachment 5599] Suggested patch for KWQKURL.mm::appendEscapingBadChars()

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jan 10 15:08:06 PST 2006

Darin Adler <darin at apple.com> has denied Henrik Grubbström
<grubba at grubba.org>'s request for review:
Bug 6452: KIO::appendEscapingBadChars() doesn't know about %u-escaping.

Attachment 5599: Suggested patch for KWQKURL.mm::appendEscapingBadChars()

------- Additional Comments from Darin Adler <darin at apple.com>
First, thanks for submitting this patch. It seems quite important to fix this

But I don't think this fix is correct.

I think we should either be escaping all % characters in the string or not
escaping any. It doesn't seem right to decide whether to escape the % character
based on whether it's followed by u201F (for example) or not.

If we shouldn't be escaping "%" characters in this case, then we need to change
KURL behavior, perhaps adding a parameter if we don't always want that

More information about the webkit-reviews mailing list