[webkit-reviews] review denied: [Bug 6465] Replace CFDictionary in
KWQAccessibilityCache with HashMap :
[Attachment 5595] Proposed patch.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Jan 10 04:17:58 PST 2006
Eric Seidel <macdome at opendarwin.org> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 6465: Replace CFDictionary in KWQAccessibilityCache with HashMap
http://bugzilla.opendarwin.org/show_bug.cgi?id=6465
Attachment 5595: Proposed patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=5595&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Nope. This patch is wrong. I was using a bad idiom:
map->find(key)->second
which is unsafe.
I should have been using:
map->get(get)
I'll post a patch with this fixed.
More information about the webkit-reviews
mailing list