[webkit-reviews] review denied: [Bug 5748] KCanvas needs to be redesigned to fill & stroke at once : [Attachment 5551] new renderstyle refactor - compiling, taking in most of previous suggestions with exception of static's and shared solid/image painter

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jan 8 13:09:49 PST 2006


Eric Seidel <macdome at opendarwin.org> has denied Alexander Kellett
<webkit at lypanov.net>'s request for review:
Bug 5748: KCanvas needs to be redesigned to fill & stroke at once
http://bugzilla.opendarwin.org/show_bug.cgi?id=5748

Attachment 5551: new renderstyle refactor - compiling, taking in most of
previous suggestions with exception of static's and shared solid/image painter
http://bugzilla.opendarwin.org/attachment.cgi?id=5551&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
We dicussed a few minor things over IRC.  This patch in general looks fabulous.


A couple reminders:
1.  ChangeLog entry should be included in your final patch
2.  Make sure you update the copyright on any files you touch.
3.  Please post a (separate) patch containing the expected changes to the
layout tests.
4.  Also, if you think this could in any way affect normal rendering, please
post (a) new layout test(s) demonstrating those changes.



More information about the webkit-reviews mailing list