[webkit-reviews] review denied: [Bug 6402] Implement frameElement.width and frameElement.height : [Attachment 5521] revised patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jan 7 08:51:49 PST 2006

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 6402: Implement frameElement.width and frameElement.height

Attachment 5521: revised patch

------- Additional Comments from Darin Adler <darin at apple.com>
In the frameWidth and frameHeight functions, there's an assumption that both
getDocument() and m_render are non-0.

I'm certain that's not correct for m_render. You can easily get a pointer to a
frame element that no longer has a renderer (perhaps it was removed from the
DOM tree) and then calling the function will do a nil-deref.

Similarly, I believe there are circumstances where you could have a reference
to a frame element that does not have a document (although I'm not certain
about that one).

Please add the checks for 0.

Also seems better to not have a space in the header between frameWidth and
frameHeight declarations.

Looks fine otherwise.

More information about the webkit-reviews mailing list