[webkit-reviews] review denied: [Bug 5291] FORM multipart/form-data with GET method issue : [Attachment 5482] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Jan 4 10:41:20 PST 2006

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 5291: FORM multipart/form-data with GET method issue

Attachment 5482: proposed fix

------- Additional Comments from Darin Adler <darin at apple.com>
This patch looks OK, but I think we can do better.

The way the code is currently written, behavior is different based on the order
of the enctype and method attributes. This patch doesn't fix that. In
particular, if enctype="multipart/form-data" before after method="get" then the
method will be GET, but if method="get" comes before
enctype="multipart/form-data" then the method will be POST.

We should remove all the order dependencies -- this patch removes one of them.

More information about the webkit-reviews mailing list