[webkit-reviews] review denied: [Bug 6361] Add plugin support to DumpRenderTree : [Attachment 5467] Fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jan 3 22:21:47 PST 2006

Eric Seidel <macdome at opendarwin.org> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 6361: Add plugin support to DumpRenderTree

Attachment 5467: Fix

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Index: WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/ggaren.mode2

should be removed.

Wouldn't it be easier to add a hidden pref to WebKit to turn off the
don't-load-plugins-with-no-window optimization?

I'm not sure that the plugin should be under the APSL (I think that's what that
is?).Probably BSD like the rest of WebKit.

It looks like you used some tabs in at least the plugin code.

No {} around the one line if in plugin code.  Also, you're likely using C99 and
can put the int in the for declaration.

In c code our unofficall style is (I'm told) to put the * next to the variable
name, not the type.  c++ we put the * next to the type.  Confusing enough yet?

I think this one could use one more round of cleanup.  Removing the mode file
will reduce the size of the patch by 2/3rds :)	I've looked at it, but not
closely enough to really call this a review yet.

More information about the webkit-reviews mailing list