[webkit-reviews] review denied: [Bug 6343] Some silly reshuffling of kwq and khtml code : [Attachment 5435] kwq reshuffling patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jan 3 13:51:02 PST 2006

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 6343: Some silly reshuffling of kwq and khtml code

Attachment 5435: kwq reshuffling patch

------- Additional Comments from Darin Adler <darin at apple.com>
I'm concerned about making the first family be a separate allocated block
instead of part of the FontDef structure. I'd expect that would create a

Also, the == for FontDef now compares the family by pointer instead of by
value, which could give false negatives for families that are in fact equal.

Similar issues in QFont. Note for example that QFont::setFamily will set the
family on a shared KWQFontFamily now, and that is different from before.

The patch includes some tabs.

Otherwise, looks fine to me.

More information about the webkit-reviews mailing list