[webkit-reviews] review requested: [Bug 6345] REGRESSION: repro crash when specifying an invalid value for the charset attribute of a <script> : [Attachment 5454] The fix (with a small amount of unrelated cleanup)

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 6345: REGRESSION: repro crash when specifying an invalid value for the
charset attribute of a <script>
http://bugzilla.opendarwin.org/show_bug.cgi?id=6345

Attachment 5454: The fix (with a small amount of unrelated cleanup)
http://bugzilla.opendarwin.org/attachment.cgi?id=5454&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Note, this fixes 2 of the 3 places I changed from KCharsets::codecForName to
QTextCodec::codecForName.  The 3rd case (found in
khtml/html/html_formimpl.cpp), I didn't change.  The code there seems to
*expect* that codec for name might return NULL, where has
KCharset::codecForName never returned NULL.  It seems that if the first charset
listed was "invalid" we would assume the page was supposed to be latin1, now we
(hopefully correctly) go through the entire list, looking for a valid charset
first.