[webkit-reviews] review granted: [Bug 6341] Move frame traversal logic from WebFrame to WebBridge : [Attachment 5434] the patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jan 2 20:55:26 PST 2006

Eric Seidel <macdome at opendarwin.org> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 6341: Move frame traversal logic from WebFrame to WebBridge

Attachment 5434: the patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks sane to me.

I saw one tab in:
+- (WebBridge *)traverseNextFrameStayWithin:(WebBridge *)stayWithin

Also, incidentally, I hate variable names like "fv" if you share my hatred you
could consider making those more legible as you update/move that code.

Finally I asked you over IRC if there were any leaks... which it seems there
were not.


More information about the webkit-reviews mailing list