[webkit-reviews] review granted: [Bug 5609] XSLT document() doesn't
handle relative paths : [Attachment 5432] updated patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Jan 2 17:43:05 PST 2006
Eric Seidel <macdome at opendarwin.org> has granted Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 5609: XSLT document() doesn't handle relative paths
http://bugzilla.opendarwin.org/show_bug.cgi?id=5609
Attachment 5432: updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=5432&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
(const char *)xmlNodeGetBase(((xsltTransformContextPtr)ctxt)->document->doc,
((xsltTransformContextPtr)ctxt)->node)
Could be made slightly clearer using a local variable.
Otherwise it looks totally fine. I don't have quite enough xlst-fu to
understand your test case, but I trust you.
More information about the webkit-reviews
mailing list