[webkit-reviews] review denied: [Bug 5609] XSLT document() doesn't handle relative paths : [Attachment 5427] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jan 2 16:20:44 PST 2006

Eric Seidel <macdome at opendarwin.org> has denied Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 5609: XSLT document() doesn't handle relative paths

Attachment 5427: proposed fix

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I talked with ap on irc.  I'm dubious about the ascii() to utf8() change, as it
was my impression that all libxml2 apis which specify const char * take a
latin1 string, those which specify xmlChar * take a utf8 string.  But I could
be wrong.  I asked him to provide a test case for this change.

Darin also pointed out a problem with ap's URL manipulation on irc, so r- this

More information about the webkit-reviews mailing list