[webkit-reviews] review requested: [Bug 6219] Perf regression: -[NSImage initWithData:] called repeatedly while moving the cursor over an image : [Attachment 5406] Change pixmap() to return a const QPixmap&

[bugzilla-request-daemon at opendarwin.org]

opendarwin.org at mitzpettel.com has asked  for review:
Bug 6219: Perf regression: -[NSImage initWithData:] called repeatedly while
moving the cursor over an image
http://bugzilla.opendarwin.org/show_bug.cgi?id=6219

Attachment 5406: Change pixmap() to return a const QPixmap&
http://bugzilla.opendarwin.org/attachment.cgi?id=5406&action=edit

------- Additional Comments from opendarwin.org at mitzpettel.com
Maybe there should be a FIXME in WebHTMLView where it creates the NSImage
saying that it would be better to delay the actual NSImage instantiation? It
seems that in an overwhelming majority of cases, the WebElementImageKey isn't
used.

Another option, instead of using a proxy or an NSImage subclass, is to use an
NSMutableDictionary subclass for the result of -[WebHTMLView elementAtPoint:]
that knows how to generate the value of the WebElementImageKey from the
WebCoreElementImageRendererKey.