[webkit-reviews] review denied: [Bug 6252] JavaScript 1.6 Array.lastIndexOf : [Attachment 6777] Updated lastIndexOf implementation

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Feb 28 20:36:35 PST 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 6252: JavaScript 1.6 Array.lastIndexOf

Attachment 6777: Updated lastIndexOf implementation

------- Additional Comments from Darin Adler <darin at apple.com>
This code looks like it won't work in a couple of ways:

    1) If 0 is passed it looks like it will search the entire array, but that's
not what the documentation seems to call for.

    2) The for loop seems to stop with index == 1, so it will miss index == 0.

In any case, we need a test case and change log to land a change like this.
Please add a test case that covers both of these issues and test the code
before putting it up for review again.

More information about the webkit-reviews mailing list